| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Test instability when pg_dump orders by OID |
| Date: | 2025-08-20 05:11:15 |
| Message-ID: | CALdSSPghJyU+8_xGqP7a_Jn12b9OTNxSAnEBvYkescZ_CzmWwg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 10 Aug 2025 at 21:37, Noah Misch <noah(at)leadboat(dot)com> wrote:
> Thanks. Given the current state of freeze for tomorrow's release wrap, the
> decision is less obvious than usual. I'm seeing these options:
>
> 1. Remove the new assertion in v13-v18.
> 2. Push your proposed fix.
> 3. Change nothing. (This would be the choice if one is maximally concerned
> about deviating from the freeze and unconcerned about --enable-cassert
> builds of releases.)
>
> I am inclined to make today's change be (1). A fresh audit of catalog PRIMARY
> KEY and UNIQUE constraints didn't find any more missed cases, but (1) still
> feels like the right level of cautiousness. If there are no objections in the
> next 3hr, I'll proceed with (1).
>
Hi! I can see we have option (1) (28e7252 etc). Can we now move
forward with option (2) for HEAD?
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2025-08-20 05:22:58 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |
| Previous Message | Yugo Nagata | 2025-08-20 05:10:28 | Re: Allow to collect statistics on virtual generated columns |