| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT |
| Date: | 2026-03-13 13:16:34 |
| Message-ID: | CALdSSPgSLA2sZ7xY7gc-RFR4wbAamO3ORe32SyRsadZTfX+OVg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 13 Mar 2026 at 17:30, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 2026-03-12 Th 11:55 PM, jian he wrote:
> > Hi.
> >
> > The regression test was very verbose; I removed some of it.
> > Also polished function ExecEvalJsonIsPredicate a little bit.
>
>
>
> Here's a v4. I changed resultBaseType to exprBaseType - I think it's
> clearer. I also trimmed the tests a bit more, and dropped the new
> objects after testing them. The error message now shows the domain name
> rather than the underlying base type. I think that's more useful.
>
Hi!
V4 looks good. The only thing that I cannot explain is removing the
`exprtype` variable inside ExecEvalJsonIsPredicate. We can just change
its declaration to
exprtype = pred->exprBaseType if i'm not mistaken?
Anyway, LGTM
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-03-13 13:23:50 | Re: Add --extra-dependencies and immediate data dumping for pg_dump/pg_upgrade |
| Previous Message | Heikki Linnakangas | 2026-03-13 13:14:12 | Re: Add a check for interrupts in ginInsert |