Re: BUG #19013: When creating a table with the "...LIKE...INCLUDING ALL" construct, REPLICA IDENTITY output is wrong

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: "dbman(at)sqlexec(dot)com" <dbman(at)sqlexec(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #19013: When creating a table with the "...LIKE...INCLUDING ALL" construct, REPLICA IDENTITY output is wrong
Date: 2025-08-06 16:32:59
Message-ID: CALdSSPg1Y2UGAWRYOu3q5SLNYzw1T-U4m95SHyMW6k64+veyZw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi!

On Wed, 6 Aug 2025 at 20:42, dbman(at)sqlexec(dot)com <dbman(at)sqlexec(dot)com> wrote:
> Good point aboutg the default value for pg_class.relreplident is always "d", but maybe it should be "n" which indicates there is no REPLICA IDENTITY.
So, in other words, you propose to change the default behaviour?

> Othewise you have an unintended DDL change consequence to this action.

It's hard (to me, at least) to say what is `intended` DDL here.

> Perhaps add a warning about this in the description for CREATE...LIKE in the docs, or even mention it in the section that describes REPLICA IDENTITY, or both.

Perhaps, rewording docs to indicate something like this does not sound
horribly to me.

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message dbman@sqlexec.com 2025-08-06 16:52:28 Re: BUG #19013: When creating a table with the "...LIKE...INCLUDING ALL" construct, REPLICA IDENTITY output is wrong
Previous Message dbman@sqlexec.com 2025-08-06 15:42:06 Re: BUG #19013: When creating a table with the "...LIKE...INCLUDING ALL" construct, REPLICA IDENTITY output is wrong