From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Steve Chavez <steve(at)supabase(dot)io>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Allow placeholders in ALTER ROLE w/o superuser |
Date: | 2023-01-03 11:20:38 |
Message-ID: | CALT9ZEHDnNVEYAgKnpMiYp2pt3dG_r6DKqgBe18fse2X0TCnqg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, Alexander!
On Tue, 3 Jan 2023 at 13:48, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Tue, Jan 3, 2023 at 11:51 AM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> > On Tue, 3 Jan 2023 at 09:29, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > >
> > > On Mon, Jan 2, 2023 at 6:42 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > > > On Mon, Jan 02, 2023 at 06:14:48PM +0300, Alexander Korotkov wrote:
> > > > > I'm going to push this if no objections.
> > > >
> > > > I also suggest that meson.build should not copy regress_args.
> > >
> > > Good point, thanks.
> > Nice, thanks!
> > Isn't there the same reason to remove regress_args from meson.build in
> > oat's test and possibly from other modules with runningcheck=false?
>
> This makes sense to me too. I don't see anything specific in oat's
> regression test that requires setting regress_args.
Yes, it seems so.
Regress args in oat's Makefile are added as a response to a buildfarm
issues by 7c51b7f7cc08. They seem unneeded to be copied into
meson.build with runningcheck=false. I may mistake but it seems to me
that removing regress_args from meson.build with runningcheck=false is
just to make it neat, not for functionality. So I consider fixing it
in pg_db_role_setting, oat, or both of them optional.
Regards,
Pavel Borisov.
From | Date | Subject | |
---|---|---|---|
Next Message | shveta malik | 2023-01-03 11:22:08 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
Previous Message | Amit Kapila | 2023-01-03 11:19:04 | Re: Question about initial logical decoding snapshot |