| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inherit regression outputs rows in alternative ordering when run on other table AM than heap |
| Date: | 2026-03-27 13:45:09 |
| Message-ID: | CALT9ZEHB5MWPa=RTUKQO1XmxVrNc8L2d3Dn6CMTtvBHkZS-=pw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, hackers!
On Fri, 27 Mar 2026 at 16:54, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>
> Hi, hackers!
>
> Existing inherit regression test results are tied to the particular
> row order after UPDATE clause. The context is approximately the same
> as in [1].
> This could be easily fixed by adding ORDER BY clause to the test. See
> the patch proposed. I added order by not only to places prone to the
> difference quoted but also to other places as it's cheap and doesn't
> harm. If the committer don't agree with extra order by's I can leave
> only those necessary for fixing quoted test output.
>
> [1] https://github.com/postgres/postgres/commit/4c1a27e53a508f74883cda52a6c8612121d7fd6b
To existing unchanged patch 0001, I've added a couple of others:
0002: Fixes join order differences.
The patch fixes only particular fail that I'm seeing.
0003: Fixed updatable view order differences.
It's carpet replacement of the test with adding ORDER BY's.
Kind regards,
Pavel Borisov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Stabilize-output-of-inherit-regression-test.patch | application/octet-stream | 21.1 KB |
| v2-0002-Stabilize-output-of-join-regression-test.patch | application/octet-stream | 3.3 KB |
| v2-0003-Stabilize-output-of-updatable_views-regression-te.patch | application/octet-stream | 18.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-03-27 13:47:36 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Peter Eisentraut | 2026-03-27 13:32:27 | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |