| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kirill Reshke <reshke(at)double(dot)cloud>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use fadvise in wal replay |
| Date: | 2022-11-25 21:10:57 |
| Message-ID: | CALT9ZEGvS2umu65qUJsLd=J7Hx9EpSuQYwQC3O-YUYMUf2nmFA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, hackers!
On Sun, 13 Nov 2022 at 02:02, Andrey Borodin <amborodin86(at)gmail(dot)com> wrote:
>
> On Sun, Aug 7, 2022 at 9:41 AM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> >
>
> Hi everyone. The patch is 16 lines, looks harmless and with proven
> benefits. I'm moving this into RfC.
As I've written up in the thread we can not gain much from this
optimization. The results of Jakub shows around 2% difference:
>baseline, master, default Linux readahead (128kb):
>33.979, 0.478
>35.137, 0.504
>34.649, 0.518>
>master+patched, readahead disabled:
>34.338, 0.528
>34.568, 0.575
>34.007, 1.136
>master+patched, readahead enabled (as default):
>33.935, 0.523
>34.109, 0.501
>33.408, 0.557
On the other hand, the patch indeed is tiny and I don't think the
proposed advise can ever make things bad. So, I've looked through the
patch again and I agree it can be committed in the current state.
Kind regards,
Pavel Borisov,
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-11-25 21:27:04 | Small miscellaneus fixes (Part II) |
| Previous Message | Bruce Momjian | 2022-11-25 20:20:02 | Re: Report roles in pg_upgrade pg_ prefix check |