| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: Unit tests for SLRU |
| Date: | 2022-04-01 08:58:35 |
| Message-ID: | CALT9ZEGf5YW7iw90U+CDj7CpwbZSN4Qh+MMJwKm+E1jNY1K78A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
пт, 1 апр. 2022 г. в 07:47, Noah Misch <noah(at)leadboat(dot)com>:
> On Thu, Mar 31, 2022 at 05:30:41PM +0300, Aleksander Alekseev wrote:
> > I used src/test/modules/test_* modules as an example.
>
> > If time permits, please take a quick look at the patch and let me know
> > if I'm moving the right direction. There will be more tests in the
> > final version, but I would appreciate an early feedback.
>
> The default place for this kind of test is regress.c, with plain "make
> check"
> calling the regress.c function. src/test/modules is for things requiring
> an
> extension module or otherwise unable to run through regress.c.
>
+1 for placement c functions into regress.c if it's possible for the aim of
simplification.
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-04-01 09:00:00 | Re: pg_rewind copies |
| Previous Message | Matthias van de Meent | 2022-04-01 08:50:07 | Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas |