Re: [PATCH] intXshr, intXshl: return error on shift count out of range

From: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
To: Egor Ivkov <e(dot)ivkov(at)arenadata(dot)io>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ilya Khaprov <i(dot)khaprov(at)arenadata(dot)io>
Subject: Re: [PATCH] intXshr, intXshl: return error on shift count out of range
Date: 2026-09-30 14:28:12
Message-ID: CALT9ZEGJxDP6SCWzpKFiRCtD4oaENPsCrmP6SVYoaJEMQXRfMQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Egor!

On Wed, 30 Sept 2026 at 18:03, Egor Ivkov <e(dot)ivkov(at)arenadata(dot)io> wrote:
>
> Small fix for .out files to contain rightmost spaces.
>
> Regards,
> Egor Ivkov

Your patch looks good to me except the similar behavior of int2 and
int4 are never explained. In C11 and older int16 left arg bit shift
is not UB only if the result filts int32. There is no check for this
in the patch.

Regards,
Pavel Borisov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2026-09-30 14:41:45 Re: REPACK (CONCURRENTLY) might keep dropped-column data
Previous Message Alexandre Felipe 2026-09-30 14:16:34 Re: BUG #19686: Rolling back SET TABLESPACE