| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Partition Check not updated when insert into a partition |
| Date: | 2021-10-18 16:56:25 |
| Message-ID: | CALT9ZEG4ZjVKRt0KNCahGnN6tAR26oT83uOYYifDPH7=Qi-usw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Oops, you're right. I had failed to notice when reading the code that
> the second transaction takes an AccessExclusiveLock on the target
> partition. Reverted back to how this was in v3.
>
> > Also I'd recommend removing the link to a discussion from the test.
> Anyway we have link in a commit message.
> > -- Report:
> https://postgr.es/m/OS3PR01MB5718DA1C4609A25186D1FBF194089%40OS3PR01MB5718.jpnprd01.prod.outlook.com
>
> Yeah, maybe the link is unnecessary in the test comment, so removed.
> Though, I do occasionally see one of those in the test files (try `git
> grep https src/test`).
>
Thanks! I don't see problems anymore. The patch is RFC now.
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-10-18 17:09:08 | Re: Partition Check not updated when insert into a partition |
| Previous Message | Alvaro Herrera | 2021-10-18 16:54:56 | Re: [PATCH] Proposal for HIDDEN/INVISIBLE column |