| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Remove workarounds to format [u]int64's |
| Date: | 2022-03-21 09:30:59 |
| Message-ID: | CALT9ZEFvsswERHm5oJ_-57gQzugxLVbjuwgtSj-Niow7tC7Y_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> > Probably you can do (long long) instead of (long long int). It is
> shorter and this is used elsewhere in the code.
>
> Thanks! Here is the updated patch. I also added Reviewed-by: and
> Discussion: to the commit message.
>
Thanks, Alexander!
I suggest the patch is in a good shape to be committed.
(
Maybe some strings that don't fit screen cloud be reflowed:
(long long int)seqdataform->last_value, (long long int)seqform->seqmax)));
)
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2022-03-21 09:41:57 | Re: Problem with moderation of messages with patched attached. |
| Previous Message | Aleksander Alekseev | 2022-03-21 09:23:33 | Re: [PATCH] Remove workarounds to format [u]int64's |