Re: Table AM Interface Enhancements

From: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Table AM Interface Enhancements
Date: 2024-03-22 04:56:33
Message-ID: CALT9ZEFVRmQfFrawTnHNCRxY1Nc+gV-wbZKrCKO4H9kA0i-8tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 22 Mar 2024 at 08:51, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:

> Hi, Alexander!
>
> Thank you for working on this patchset and pushing some of these patches!
>
> I tried to write comments for tts_minimal_is_current_xact_tuple()
> and tts_minimal_getsomeattrs() for them to be the same as for the same
> functions for heap and virtual tuple slots, as I proposed above in the
> thread. (tts_minimal_getsysattr is not introduced by the current patchset,
> but anyway)
>
> Meanwhile I found that (never appearing) error message
> for tts_minimal_is_current_xact_tuple needs to be corrected. Please see the
> patch in the attachment.
>
> I need to correct myself: it's for tts_minimal_getsysattr() not
tts_minimal_getsomeattrs()

Pavel.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-03-22 05:19:17 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message Pavel Borisov 2024-03-22 04:51:31 Re: Table AM Interface Enhancements