| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Unit tests for SLRU |
| Date: | 2022-04-13 11:51:30 |
| Message-ID: | CALT9ZEF447SpmPAOKipZz9zkHyRvQ8835cV8c71+9RFNT+UG4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Hi hackers,
>
> > Here is version 3 of the patch.
> > [...]
> > I think the tests are about as good as they will ever get.
>
> Here is version 4. Same as v3, but with resolved conflicts against the
> current `master` branch.
>
Hi, Alexander!
The test seems good enough to be pushed.
Only one thing to note. Maybe it would be good not to copy-paste Assert
after every call of SimpleLruInit, putting it into the wrapper function
instead. So the test can call calling the inner function (without assert)
and all other callers using the wrapper. Not sure about naming though.
Maybe rename current SimpleLruInit -> SimpleLruInitInner and a new wrapper
being under the old name (SimpleLruInit).
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-04-13 11:54:12 | Re: should frontend tools use syncfs() ? |
| Previous Message | Daniel Gustafsson | 2022-04-13 11:51:16 | Error logging messages |