| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2026-06-30 11:25:31 |
| Message-ID: | CALT9ZEEuOmeJFNUviG4F+ExsVzreBV6=GPRWh-BX0rD4ejPtNA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Alexander!
On Tue, 30 Jun 2026 at 15:07, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Fri, Jun 26, 2026 at 10:50 PM Alexander Korotkov
> <aekorotkov(at)gmail(dot)com> wrote:
> > On Fri, Jun 26, 2026 at 6:20 PM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
> > > If we exclude case with DEFAULT partition, MERGE PARTITIONS command was
> > > intended to be used when an incorrect table partitioning was chosen.
> > > For example, a table was initially partitioned by month, but later we
> > > needed to change table partitioning by quarter. In this case, MERGE
> > > PARTITIONS command should merge several adjacent partitions into one.
> > > Current checks are made for this case.
> > >
> > > >- If there's *no* default partition, then I think the check should be
> > > >relaxed; it's sufficient to verify that the bounds of the merged
> > > >partition do not overlap with any partition which is not being merged;
> > >
> > > It's probably possible to do this. But in this case, the command will
> > > not exactly be "MERGE PARTITIONS" ("MERGE PARTITIONS & EXPAND"?).
> >
> > +1,
> > We can implement a support for this for 20. For 19, I propose to
> > state the restriction more explicit in the docs. See the attached
> > patch.
>
> I'm going to push the docs patch if no objections.
I looked at the doc patch. IMO "in order to be merged" is redundant.
I'd propose following:
"For range-partitioned tables, the ranges of merged partitions must be
adjacent. This applies even if the partitioned table has no default
partition."
Regards,
Pavel Borisov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | prankware | 2026-06-30 11:26:05 | COALESCE patch |
| Previous Message | Akshay Joshi | 2026-06-30 11:18:26 | Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement |