| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Partition Check not updated when insert into a partition |
| Date: | 2021-10-06 13:40:37 |
| Message-ID: | CALT9ZEEALh0jRWYfEfnZ4W7vpa5kUkGwaqAi0MCX=GtTNNO1Uw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, hackers!
We've reviewed patch v3 and found it right. Completely agree that in case
we attach/detach partition relcaches for all child relations (if they
exist) need invalidation.
Installcheck world succeeds after the patch. Tests from the patch fail as
they should when run on the master branch. Found no problems.
Overall patch is good and I'd recommend it to be committed.
We've made v4 patch according to Nitin's advice and tested it, but still
have no objections to patch v3. Each can be committed, equally good.
Big thanks to you, Álvaro and Amit for working on this!
--
Best regards,
Pavel Borisov, Maxim Orlov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-ATTACH-DETACH-PARTITION-to-invalidate-partiti.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2021-10-06 13:54:23 | Re: using an end-of-recovery record in all cases |
| Previous Message | Bruce Momjian | 2021-10-06 13:35:41 | Re: storing an explicit nonce |