| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com> |
| Cc: | "pryzby(at)telsasoft(dot)com" <pryzby(at)telsasoft(dot)com>, "soumyadeep2007(at)gmail(dot)com" <soumyadeep2007(at)gmail(dot)com>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "Ashwin Agrawal (Pivotal)" <aagrawal(at)pivotal(dot)io>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "melanieplageman(at)gmail(dot)com" <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Table AM modifications to accept column projection lists |
| Date: | 2021-03-02 18:35:06 |
| Message-ID: | CALNJ-vTaUkJeLU0qEZ0H9jJMHo0GqHeOTnJYy_TbeiwZtdUh=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
+ /* Make sure the the new slot is not dependent on the original tuple */
There is duplicate 'the'.
For neededColumnContextWalker(),
+ else if(var->varattno == 0) {
I think the if following the else is not needed - I assume var->varattno
wouldn't be negative.
Similar comment for extract_scan_columns().
+ while ((col = bms_next_member(parent_cols, col)) >= 0)
+ {
+ Var *var = (Var *) list_nth(translated_vars, col - 1);
If col is 0, do you still want to call list_nth() ?
Cheers
On Tue, Mar 2, 2021 at 9:10 AM Jacob Champion <pchampion(at)vmware(dot)com> wrote:
> On Mon, 2021-03-01 at 23:13 +0000, Jacob Champion wrote:
> > On Mon, 2021-03-01 at 16:59 -0600, Justin Pryzby wrote:
> > > Why is this removed ?
> >
> > Mm, both of those analyze.c changes seem suspect. Possibly a mismerge
> > from the zedstore branch; let me double-check.
> >
> > > its (possessive) not it's ("it is")
> >
> > Thanks, I'll fix this at the same time.
>
> Both fixed in v3; thanks for the catch!
>
> --Jacob
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Nascimento | 2021-03-02 18:42:27 | Re: PROXY protocol support |
| Previous Message | Tom Lane | 2021-03-02 18:28:01 | Re: [PATCH] Support empty ranges with bounds information |