Re: [POC] Allow flattening of subquery with a link to upper query

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [POC] Allow flattening of subquery with a link to upper query
Date: 2022-10-04 21:45:11
Message-ID: CALNJ-vTa5VgvV1NPRHnypdnbx-fhDu7vWp73EkMUbZRpNHTYQQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
For contain_placeholders():

+ if (IsA(node, Query))
+ return query_tree_walker((Query *) node, contain_placeholders,
context, 0);
+ else if (IsA(node, PlaceHolderVar))

The `else` is not needed.

For correlated_t struct, it would be better if the fields have comments.

+ * (for grouping, as an example). So, revert its status
to
+ * a full valued entry.

full valued -> fully valued

Cheers

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-10-04 22:07:49 Re: Warning about using pg_stat_reset() and pg_stat_reset_shared()
Previous Message Nikita Malakhov 2022-10-04 19:41:22 Re: Pluggable toaster