Re: pgsql: autovacuum: handle analyze for partitioned tables

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: autovacuum: handle analyze for partitioned tables
Date: 2021-04-08 20:25:24
Message-ID: CALNJ-vTHK-s41LFrizOpMN6n6tKGBMt9UUOY=SFHNWcCy-2tQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Apr 8, 2021 at 1:12 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:

> On 2021-Apr-08, Tom Lane wrote:
>
> > > So I tend to think that my initial instinct was the better direction:
> we
> > > should not be doing any find_all_inheritors() here at all, but instead
> > > rely on pg_class.reltuples to be set for the partitioned table.
> >
> > +1
>
> This patch does that.
>
> --
> Álvaro Herrera 39°49'30"S 73°17'W
> "I dream about dreams about dreams", sang the nightingale
> under the pale moon (Sandman)
>

Hi,
Within truncate_update_partedrel_stats(), dirty is declared within the loop.
+ if (rd_rel->reltuples != 0)
+ {
...
+ if (dirty)

The two if blocks can be merged. The variable dirty can be dropped.

Cheers

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-04-08 21:29:51 Re: pgsql: autovacuum: handle analyze for partitioned tables
Previous Message Alvaro Herrera 2021-04-08 20:11:49 Re: pgsql: autovacuum: handle analyze for partitioned tables

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-04-08 20:57:59 Re: Dubious coding in nbtinsert.c
Previous Message Alvaro Herrera 2021-04-08 20:11:49 Re: pgsql: autovacuum: handle analyze for partitioned tables