Re: Bugs in copyfuncs/equalfuncs support for JSON node types

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bugs in copyfuncs/equalfuncs support for JSON node types
Date: 2022-07-05 01:48:48
Message-ID: CALNJ-vT8OL3E5LNx4D+ubUe9JBJWydEXn60j0=ca+w+wio+79g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 4, 2022 at 6:23 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> In reviewing Peter's patch to auto-generate the backend/nodes
> support files, I compared what the patch's script produces to
> what is in the code now. I found several discrepancies in the
> recently-added parse node types for JSON functions, and as far
> as I can see every one of those discrepancies is an error in
> the existing code. Some of them are relatively harmless
> (e.g. COPY_LOCATION_FIELD isn't really different from
> COPY_SCALAR_FIELD), but some of them definitely are live bugs.
> I propose the attached patch.
>
> regards, tom lane
>
> Hi,
Patch looks good to me.

Thanks

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-05 01:56:24 Re: TAP output format in pg_regress
Previous Message Tom Lane 2022-07-05 01:23:08 Bugs in copyfuncs/equalfuncs support for JSON node types