Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)
Date: 2021-02-13 21:12:25
Message-ID: CALNJ-vSuoadaNvf6HuCMQ1638DiDWmN4ULyJxvtL0iP=JDh9aA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Patch v4 corrects a small typo:
+ (errmsg("BaseSnapshot cant't be setup at point %X/%X",

Cheers

On Sat, Feb 13, 2021 at 12:58 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:

> Em sáb., 13 de fev. de 2021 às 17:48, Zhihong Yu <zyu(at)yugabyte(dot)com>
> escreveu:
>
>> Hi,
>> + (errmsg("BaseSnapshot cant't be setup at point %X/%X",
>> + (uint32) (lsn >> 32), (uint32) lsn),
>> + errdetail("Top transaction is running.")));
>>
>> Did you mean this errdetail:
>>
>> Top transaction is not running.
>>
> Done.
>
> Thanks Zhihong.
> v3 based on your patch, attached.
>
> regards,
> Ranier Vilela
>

Attachment Content-Type Size
reorder-buffer-v4.patch application/octet-stream 3.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-02-13 21:23:40 Re: How to get Relation tuples in C function
Previous Message Tom Lane 2021-02-13 21:11:37 Re: Some regular-expression performance hacking