| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Edmund Horner <ejrh00(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tid scan improvements |
| Date: | 2021-01-26 02:50:02 |
| Message-ID: | CALNJ-vSjPS=kb4DHQ3a57CO+hX3e_Na+emSZVw1tmM9Vcz18Xg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
bq. within this range. Table AMs where scanning ranges of TIDs does not
make
sense or is difficult to implement efficiently may choose to not implement
Is there criterion on how to judge efficiency ?
+ if (tidopexpr->exprtype == TIDEXPR_LOWER_BOUND)
...
+ if (tidopexpr->exprtype == TIDEXPR_UPPER_BOUND)
The if statement for upper bound should be prefixed with 'else', right ?
+ * TidRecheck -- access method routine to recheck a tuple in EvalPlanQual
...
+TidRangeRecheck(TidRangeScanState *node, TupleTableSlot *slot)
The method name in the comment doesn't match the real method name.
+ * ExecTidRangeScan(node)
...
+ExecTidRangeScan(PlanState *pstate)
Parameter names don't match.
Cheers
On Mon, Jan 25, 2021 at 5:23 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Thu, 21 Jan 2021 at 18:16, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I've implemented this in the attached.
>
> The bug fix in 0001 is now committed, so I'm just attaching the 0002
> patch again after having rebased... This is mostly just to keep the
> CFbot happy.
>
> David
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2021-01-26 02:54:10 | Re: Code of Conduct plan,Re: Code of Conduct plan,Re: Code of Conduct plan,Re: Code of Conduct plan |
| Previous Message | Thomas Munro | 2021-01-26 02:43:29 | Re: fdatasync(2) on macOS |