| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REINDEX backend filtering |
| Date: | 2021-02-07 16:16:44 |
| Message-ID: | CALNJ-vS+gXt0OYBg671k9fVHWTUu+1cpNfoOA3PUsZKJp8Ey4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
For index_has_deprecated_collation(),
+ object.objectSubId = 0;
The objectSubId field is not accessed
by do_check_index_has_deprecated_collation(). Does it need to be assigned ?
For RelationGetIndexListFiltered(), it seems when (options &
REINDEXOPT_COLL_NOT_CURRENT) == 0, the full_list would be returned.
This can be checked prior to entering the foreach loop.
Cheers
On Sat, Feb 6, 2021 at 11:20 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Thu, Jan 21, 2021 at 11:12:56AM +0800, Julien Rouhaud wrote:
> >
> > There was a conflict with a3dc926009be8 (Refactor option handling of
> > CLUSTER, REINDEX and VACUUM), so rebased version attached. No other
> > changes included yet.
>
> New conflict, v3 attached.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-02-07 16:27:01 | Re: jsonb_array_elements_recursive() |
| Previous Message | Tom Lane | 2021-02-07 16:09:49 | Re: Prevent printing "next step instructions" in initdb and pg_upgrade |