Re: [PATCH] Optimize json_lex_string by batching character copying

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Optimize json_lex_string by batching character copying
Date: 2022-06-24 20:58:08
Message-ID: CALNJ-vRZhA2d+k8XD7P5mLYEC_m9bdPL9gx8Ys+475=BiSa=gw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Looking at the patch,

+ if (copyable_characters_length)
+ {
+ /* flush copyable characters */
+ appendBinaryStringInfo(
+ lex->strval,
+ s - copyable_characters_length,
+ copyable_characters_length);
+
+ }
break;

I wonder why copyable_characters_length is not reset after flushing.

Cheers

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-06-24 21:27:28 Re: Future Postgres 15 and Clang 15
Previous Message Robert Haas 2022-06-24 20:46:42 Re: pg_auth_members.grantor is bunk