| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
| Cc: | Joel Jacobson <joel(at)compiler(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-01-28 00:32:38 |
| Message-ID: | CALNJ-vQeaH1Cv=T3jwM6PpTRon24wgLgGjq57qZpF6zZm-b6cA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Mark:
+ if (ARR_NDIM(arr) != 1 ||
+ ARR_HASNULL(arr) ||
+ ARR_ELEMTYPE(arr) != CHAROID)
+ elog(ERROR, "confreftype is not a 1-D char array");
I think the ARR_HASNULL(arr) condition is not reflected in the error
message.
+ * Array foreign keys support only UPDATE/DELETE NO ACTION,
UPDATE/DELETE
+ * RESTRICT amd DELETE CASCADE actions
I don't see CASCADE in the if condition that follows the above comment.
+ char reftype; /* FKCONSTR_REF_xxx code */
The code would be FKCONSTR_REF_EACH_ELEMENT and FKCONSTR_REF_PLAIN. I think
you can mention them in the comment.
Cheers
On Wed, Jan 27, 2021 at 11:34 AM Mark Rofail <markm(dot)rofail(at)gmail(dot)com> wrote:
> Hello Joel,
>
>
>> I think you forgot to attach the patch.
>>
> Appears so, sorry about that.
>
> Here it is.
>
> /Mark
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2021-01-28 00:44:06 | RE: Enhance traceability of wal_level changes for backup management |
| Previous Message | John Naylor | 2021-01-27 23:23:38 | Re: Perform COPY FROM encoding conversions in larger chunks |