| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: heavily contended lwlocks with long wait queues scale badly |
| Date: | 2022-11-01 00:17:03 |
| Message-ID: | CALNJ-vQYE8USe+MsrmOTUsP-k=y=nqWDABObzA4B515t-htswQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 31, 2022 at 4:51 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2022-10-31 16:21:06 +0530, Bharath Rupireddy wrote:
> > BTW, I've seen a sporadic crash (SEGV) with the patch in bg writer
> > with the same set up [1], I'm not sure if it's really because of the
> > patch. I'm unable to reproduce it now and unfortunately I didn't
> > capture further details when it occurred.
>
> That's likely because the prototype patch I submitted in this thread missed
> updating LWLockUpdateVar().
>
> Updated patch attached.
>
> Greetings,
>
> Andres Freund
>
Hi,
Minor comment:
+ uint8 lwWaiting; /* see LWLockWaitState */
Why not declare `lwWaiting` of type LWLockWaitState ?
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-01 00:19:02 | Re: Making Vars outer-join aware |
| Previous Message | Andres Freund | 2022-11-01 00:16:25 | Re: resowner "cold start" overhead |