| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: simplifying foreign key/RI checks |
| Date: | 2021-12-20 09:21:10 |
| Message-ID: | CALNJ-vQFdWqJw76yfVwUJb2=i1mQ7GnAPzG+L2TuoN7t1gnXWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 19, 2021 at 10:20 PM Amit Langote <amitlangote09(at)gmail(dot)com>
wrote:
> On Mon, Dec 20, 2021 at 2:00 PM Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
> wrote:
> > Sorry for the delay. This patch no longer applies, it has some conflict
> with d6f96ed94e73052f99a2e545ed17a8b2fdc1fb8a
>
> Thanks Corey for the heads up. Rebased with some cosmetic adjustments.
>
> Hi,
+ Assert(partidx < 0 || partidx < partdesc->nparts);
+ partoid = partdesc->oids[partidx];
If partidx < 0, do we still need to fill out partoid and is_leaf ? It seems
we can return early based on (should call table_close(rel) first):
+ /* No partition found. */
+ if (partidx < 0)
+ return NULL;
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | osumi.takamichi@fujitsu.com | 2021-12-20 09:40:19 | RE: Failed transaction statistics to measure the logical replication progress |
| Previous Message | Kyotaro Horiguchi | 2021-12-20 08:52:21 | Re: In-placre persistance change of a relation |