Re: Missing update of all_hasnulls in BRIN opclasses

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Missing update of all_hasnulls in BRIN opclasses
Date: 2022-10-22 23:02:54
Message-ID: CALNJ-vQ4oG=PheN-nM+-5oK-x_Pe5sp5yNshckTKRtkoiWAL0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Tomas:
For 0002-fixup-brin-has_nulls-20221022.patch :

+ first_row = (bval->bv_hasnulls && bval->bv_allnulls);
+
+ if (bval->bv_hasnulls && bval->bv_allnulls)

It seems the if condition can be changed to `if (first_row)` which is more
readable.

Chhers

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-10-22 23:17:55 Re: PATCH: Using BRIN indexes for sorted output
Previous Message Nikita Malakhov 2022-10-22 21:00:12 Re: Pluggable toaster