| From: | Vik Reykja <vikreykja(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Sébastien Lardière <slardiere(at)hi-media(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, cedric(at)2ndquadrant(dot)fr |
| Subject: | Re: DEALLOCATE IF EXISTS |
| Date: | 2012-10-09 14:44:07 |
| Message-ID: | CALDgxVviJKfgiE7eB9YaEq8-L8peOS3Jw845sFzB9vkjguwidQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= <slardiere(at)hi-media(dot)com> writes:
> > Indeed, brackets was not correct, it's better now (I think), and correct
> > some comments.
>
> Still wrong ... at the very least you missed copyfuncs/equalfuncs.
> In general, when adding a field to a struct, it's good practice to
> grep for all uses of that struct.
>
I don't see Sébastien's message, but I made the same mistake in my patch.
Another one is attached with copyfuncs and equalfuncs. I did a grep for
DeallocateStmt and I don't believe I have missed anything else.
Also, I'm changing the subject so as not to hijack this thread any further.
| Attachment | Content-Type | Size |
|---|---|---|
| deallocate_if_exists.2.patch | application/octet-stream | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Cédric Villemain | 2012-10-09 14:50:58 | Re: Truncate if exists |
| Previous Message | Tom Lane | 2012-10-09 14:09:14 | Re: Truncate if exists |