| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |
| Date: | 2026-04-13 03:21:06 |
| Message-ID: | CALDaNm3nucvcX_-jU-YqX2k4dTM_qY72gFbh10SnWp4gro+ifQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 13 Apr 2026 at 07:45, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Fri, Apr 10, 2026 at 8:19 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Fri, Apr 10, 2026 at 12:43 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > Notice that that the describe publication says:
> > > "Tables:" and "Except tables:" (Lowercase "tables")
> > >
> > > Notice that the describe table says:
> > > "Publications:" and "Except Publications:" (Uppercase "Publications")
> > >
> > > I think they should use a consistent case:
> > > eg1. (both lowercase) Except tables; Except publications, OR
> > > eg2. (bother uppercase) Except Tables; Except Publications
> > >
> >
> > We should follow eg1. I checked few examples where we follow same
> > pattern as eg1:
> >
> > Example-1: (See: "Tables from schemas")
> > postgres=# \dRp+ pub1
> > Publication pub1
> > Owner | All tables | All sequences | Inserts | Updates | Deletes |
> > Truncates | Generated columns | Via root | Description
> > -------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
> > amit | f | f | t | t | t | t
> > | none | f |
> > Tables from schemas:
> > "sch1"
> >
> > Example-2: ((See: "No connections")
> > postgres=# create user u1 CONNECTION LIMIT 0;
> > CREATE ROLE
> > postgres=# \du u1
> > List of roles
> > Role name | Attributes
> > -----------+----------------
> > u1 | No connections
> >
>
> Hi Amit.
>
> Thanks for the advice.
>
> PSA patch v1 to change "Except Publications" to "Except publications".
The commit message could be improved:
Date: Mon, 13 Apr 2026 12:12:00 +1000
Subject: [PATCH v1] describe table except publications
---
src/bin/psql/describe.c | 2 +-
Other than that, the patch looks good to me.
Regards,
Vignesh.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wenhui qiu | 2026-04-13 03:27:39 | Re: Propagate stadistinct through GROUP BY/DISTINCT in subqueries and CTEs |
| Previous Message | Chao Li | 2026-04-13 02:53:26 | Re: quoteOneName() inconsistency with quote_all_identifiers — replacement API proposed |