Re: Logical Replication of sequences

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2025-05-01 03:16:27
Message-ID: CALDaNm3n5T+z68GTX9PUb6L_7q4y22fi5UZ0rFxun-12zkys5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 29 Apr 2025 at 06:15, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh.
>
> Some trivial review comments for DOCS patch v20250428-0005.
>
> ======
> doc/src/sgml/logical-replication.sgml
>
> 1.
> + Publications may currently only contain tables or sequences. Objects must be
> + added explicitly, except when a publication is created using
> + <literal>FOR TABLES IN SCHEMA</literal>, or <literal>FOR ALL
> TABLES</literal>,
> + or <literal>FOR ALL SEQUENCES</literal>. Unlike tables, the current state of
> + sequences may be synchronised at any time. For more information, refer to
> + <xref linkend="logical-replication-sequences"/>.
> </para>
>
> AFAIK the PostgreSQL documentation uses US spelling:
>
> /synchronised/synchronized/
>
> ~~~
>
> 2.
> + Incremental sequence changes are not replicated. Although the data in
> + serial or identity columns backed by sequences will of course be
> + replicated as part of the table, the sequences themselves do not replicate
> + ongoing changes. On the subscriber, a sequence will retain the last value
>
> I didn't think that you needed to say "of course" here.

Thanks for the comments, the updated patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v20250501-0001-Introduce-pg_sequence_state-function-for-e.patch text/x-patch 6.7 KB
v20250501-0005-Documentation-for-sequence-synchronization.patch text/x-patch 26.1 KB
v20250501-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch text/x-patch 23.0 KB
v20250501-0004-Enhance-sequence-synchronization-during-su.patch text/x-patch 97.9 KB
v20250501-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch text/x-patch 106.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2025-05-01 03:17:05 Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Previous Message Mark Dilger 2025-05-01 01:12:33 Re: Adding skip scan (including MDAM style range skip scan) to nbtree