Re: Logical Replication of sequences

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2025-04-29 00:44:57
Message-ID: CAHut+PtNW1WfbWWpOk480PM3oVxsvufQuADYsk=RHeZe3NzQgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Vignesh.

Some trivial review comments for DOCS patch v20250428-0005.

======
doc/src/sgml/logical-replication.sgml

1.
+ Publications may currently only contain tables or sequences. Objects must be
+ added explicitly, except when a publication is created using
+ <literal>FOR TABLES IN SCHEMA</literal>, or <literal>FOR ALL
TABLES</literal>,
+ or <literal>FOR ALL SEQUENCES</literal>. Unlike tables, the current state of
+ sequences may be synchronised at any time. For more information, refer to
+ <xref linkend="logical-replication-sequences"/>.
</para>

AFAIK the PostgreSQL documentation uses US spelling:

/synchronised/synchronized/

~~~

2.
+ Incremental sequence changes are not replicated. Although the data in
+ serial or identity columns backed by sequences will of course be
+ replicated as part of the table, the sequences themselves do not replicate
+ ongoing changes. On the subscriber, a sequence will retain the last value

I didn't think that you needed to say "of course" here.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2025-04-29 00:56:12 Re: type cache cleanup improvements
Previous Message Steve Chavez 2025-04-29 00:43:01 Re: Allow database owners to CREATE EVENT TRIGGER