Re: postgres_fdw - make cached connection functions tests meaningful

On Mon, May 10, 2021 at 6:03 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> While working on [1], I got to know that there is a new GUC
> debug_invalidate_system_caches_always that has been introduced in v14.
> It can be used to switch off cache invalidation in
> CLOBBER_CACHE_ALWAYS builds which makes cache sensitive tests stable.
> Using this GUC, it is quite possible to make cached connection
> management function tests more meaningful by returning original
> values(true/false, all the output columns) instead of SELECT 1. Note
> that the commit f77717b29 stabilized the tests for those functions -
> postgres_fdw_disconnect, postgres_fdw_disconnect_all and
> postgres_fdw_get_connections by masking actual return value of the
> functions.
>
> Attaching a patch to use the new GUC to make the functions return actual output.

The patch does not apply on Head anymore, could you rebase and post a
patch. I'm changing the status to "Waiting for Author".

Regards,
Vignesh