| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Mingjie Gao <mingjie(dot)gmj(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH v1] Fix initial sync of zero-column published tables |
| Date: | 2026-11-22 06:21:56 |
| Message-ID: | CALDaNm3NX+Uvwpu8554JuMZ1KynS58KPHcb-FBkMjG2OQKBCLg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 20 Nov 2026 at 11:50, Mingjie Gao <mingjie(dot)gmj(at)gmail(dot)com> wrote:
>
> Hi Peter, Vignesh,
>
> Peter, thanks for the comments. I've removed the version notes from the patch, reworded the NIL comments in both COPY entry points, and added a reference to attnamelist_is_explicit in the attnamelist description. The test cleanup comment now just says “Clean up.”
>
> no functional changes from v4 on master.
>
> Vignesh, I've attached v5 for master (d94964f14f3) and a separate patch for REL_15_STABLE (e5b33ff4514). The master patch also applies cleanly to PG16 through PG19. PG15 uses text for the initial copy, so the test checks the subscriber default after the initial copy and again after a replicated insert. Without the patch, neither of the two initially copied rows got the default. With the patch, both did, as did the later insert.
Thanks for the updated version, I have no more comments.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | vignesh C | 2026-11-22 04:01:11 | Re: Initial table sync copies the whole table when it is no longer published |