Re: Proposal: Conflict log history table for Logical Replication

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-11-18 10:26:37
Message-ID: CALDaNm39=JBp5Ca19LJbgC=hyHNk-NRGd3yR5T8oYKzepCoWJA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Nov 2026 at 12:48, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> My review comments for 002:
> 1) pg_dump.sgml says that pg_dump does not dump the conflict log
> table. But nothing says that pg_upgrade keeps it, along with its rows
> and privileges. Should we document that too?
> 2) Comments and security labels on the conflict log table are lost
> across pg_upgrade. COMMENT ON TABLE/COLUMN is allowed on it, but in
> binary-upgrade mode selectDumpableTable() keeps only
> DUMP_COMPONENT_DEFINITION | DUMP_COMPONENT_ACL. Should we add
> DUMP_COMPONENT_COMMENT | DUMP_COMPONENT_SECLABEL as well?
> 3) In 002_pg_dump.pl, the test 'binary upgrade: conflict log table of
> sub3' matches any "CREATE TABLE pg_conflict.pg_conflict_log_\d+". So
> it would also pass with only sub4's table, and it doesn't really check
> sub3's table. Should the regex check that the table name uses the OID
> kept for sub3?

Thanks for the comments and changes, I have merged the changes with
slight changes in the 002 patch, there are no changes in 001 and 003
patch, it is the same as the v94 version patch. The attached v95
version patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v95-0002-Preserve-conflict-log-destination-and-subscripti.patch application/octet-stream 25.9 KB
v95-0001-Record-logical-replication-conflicts-in-the-conf.patch application/octet-stream 133.4 KB
v95-0003-Add-conflict-log-table-information-to-describe-s.patch application/octet-stream 80.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Markos Fountoulakis 2026-11-18 10:46:18 Re: [PATCH] basebackup: use sequential access advice for full-file reads
Previous Message Jakub Wartak 2026-11-18 10:14:42 Re: amcheck: add index-all-keys-match verification for B-Tree