From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum |
Date: | 2020-07-05 00:59:04 |
Message-ID: | CALDaNm2rxLMbzxxabaqcg4CedLW8seHnmX1d9T0ACVDGa6S9aA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jul 4, 2020 at 12:32 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > On Fri, 3 Jul 2020 at 17:07, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > Hi,
> > >
> > > While checking through the code I found that some of the function
> > > parameters in reorderbuffer & vacuumlazy are not used. I felt this
> > > could be removed. I'm not sure if it is kept for future use or not.
> > > Attached patch contains the changes for the same.
> > > Thoughts?
> > >
> >
> > For the part of parallel vacuum change, it looks good to me.
> >
>
> Unlike ReorderBuffer, this change looks fine to me as well. This is a
> quite recent (PG13) change and it would be good to remove it now. So,
> I will push this part of change unless I hear any objection in a day
> or so.
Thanks all for your comments, attached patch has the changes that
excludes the changes made in reorderbuffer.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
0001-Removed-unused-function-parameter-in-end_parallel_va.patch | text/x-patch | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2020-07-05 01:43:10 | Re: Include access method in listTables output |
Previous Message | Jeff Davis | 2020-07-04 20:53:58 | Re: Default setting for enable_hashagg_disk (hash_mem) |