| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |
| Date: | 2024-01-27 03:26:53 |
| Message-ID: | CALDaNm2i=xY85Jhg5Pr+7-yTt_Ar3tQebrDGRvxB4j2VqWEOZw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 19 Jan 2024 at 10:50, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jan 18, 2024 at 09:25:16AM +0100, Anthonin Bonnefoy wrote:
> > From what I can tell, there's no change in the behaviour. All paths
> > would eventually go through HandleSlashCmds's cleaning logic. This is
> > also mentioned in ignore_slash_options's comment.
>
> Yeah, I can confirm that. I would be really tempted to backpatch that
> because that's a bug: we have to call ignore_slash_options() for
> inactive branches when a command parses options with OT_NORMAL. Now,
> I cannot break things, either.
>
> > Done. patch 1 adds ignore_slash_options to bind. patch 2 adds the new
> > \bindx, \close and \parse commands.
>
> 0001 has been applied on HEAD.
Since the 0001 patch has been applied, sending only 0002 as v5-0001 so
that CFBot can apply and run.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-psql-Add-support-for-prepared-stmt-with-extended-.patch | text/x-patch | 19.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-01-27 03:29:04 | Re: Support run-time partition pruning for hash join |
| Previous Message | vignesh C | 2024-01-27 03:03:01 | Re: Some revises in adding sorting path |