Re: Proposal: Conflict log history table for Logical Replication

From: vignesh C <vignesh21(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-01-01 11:04:13
Message-ID: CALDaNm2fuVjLOe5imUWjun+mBBWn2zsd3Ex-bdRDa_feMYv91w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 1 Jan 2026 at 12:32, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Jan 1, 2026 at 11:43 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> >
> > IsSystemClass(Oid relid, Form_pg_class reltuple)
> > {
> > /* IsCatalogRelationOid is a bit faster, so test that first */
> > - return (IsCatalogRelationOid(relid) || IsToastClass(reltuple));
> > + return (IsCatalogRelationOid(relid) || IsToastClass(reltuple)
> > + || IsConflictClass(reltuple));
> > }
> >
> >
> > After this change we will not be able to truncate the user created
> > tables in pg_conflict schema:
> > postgres=# create table pg_conflict.t1(c1 int);
> > CREATE TABLE
> > postgres=# insert into pg_conflict.t1 values(1);
> > INSERT 0 1
> >
>
> But do we even want to create user-tables (other than CLT) in
> pg_conflict schema? I feel operations like creation of tables or
> moving any table in and out of pg_conflict schema (as suggested in my
> previous email) should not even be allowed, similar to pg_toast.

I also felt creation of tables should not be allowed, in case we plan
to allow creation, then the other operations also should be allowed.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-01-01 11:05:14 Re: Proposal: Conflict log history table for Logical Replication
Previous Message shveta malik 2026-01-01 10:31:12 Re: Proposal: Conflict log history table for Logical Replication