| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Replication slot stats misgivings |
| Date: | 2021-04-15 07:15:36 |
| Message-ID: | CALDaNm2TX24gD8szVvTrOfWyiEuYTVKEycGTY_gd8Gdkg1qGMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 15, 2021 at 11:52 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Apr 14, 2021 at 5:52 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
>
> I have made minor changes to the 0001 and 0002 patches. Attached is
> the combined patch for them, I think we can push them as one patch.
> Changes made are (a) minor editing in comments, (b) changed the
> condition when to report stats such that unless we have processed any
> bytes, we shouldn't send those, (c) removed some unrelated changes
> from 0002, (d) ran pgindent.
>
> Let me know what you think of the attached?
Changes look fine to me, the patch applies neatly and make check-world passes.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wenjing | 2021-04-15 07:26:28 | Re: [Proposal] Global temporary tables |
| Previous Message | Ajin Cherian | 2021-04-15 06:38:40 | Re: logical replication empty transactions |