| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: sequencesync worker race with REFRESH SEQUENCES |
| Date: | 2026-07-18 14:40:13 |
| Message-ID: | CALDaNm2RP5QAF0GTcyyEsCx8SZHrRtEB4ET-bp6JfFJUqOG-jw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 18 Jul 2026 at 09:05, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> I have pushed the revert. Attached patch fixes the race without taking
> lock on pg_subscription_rel.
The changes look good to me. I verified the behavior using a debugger
on both the PG20 and PG19 branches, confirming that a concurrent
refresh successfully stops the sequence sync worker and resets the
sequences to their initial state. I also verified the fix using the
attached injection point test. I'm not entirely sure if we should
include this test in the final commit, as it requires introducing a
new injection point to the codebase.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Test-add-test-for-REFRESH-SEQUENCES-stopping-a-runni.patch | application/octet-stream | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-07-18 15:41:26 | Validate SERVER subscription conninfo during ALTER SUBSCRIPTION ... OWNER TO |
| Previous Message | ZizhuanLiu X-MAN | 2026-07-18 14:03:59 | Re: COMMENTS are not being copied in CREATE TABLE LIKE |