Re: [PATCH] Performance Improvement For Copy From Binary Files

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Performance Improvement For Copy From Binary Files
Date: 2020-07-16 17:13:20
Message-ID: CALDaNm2MKgqQdfcYAe_zNQcnezNpCkQg3fxH-aPW7wrPfVJKgQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 16, 2020 at 8:52 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Thu, Jul 16, 2020 at 7:44 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> > On Wed, Jul 15, 2020 at 1:06 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > On Wed, Jul 15, 2020 at 8:03 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > > On Tue, Jul 14, 2020 at 10:23 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > > > Rest of the changes looked fine to me. Also I noticed that
> > > > > commit message was missing in the patch.
> > >>
> > > > Please see the attached v7.
> > >
> > > Thanks for fixing the comments.
> > > Patch applies cleanly, make check & make check-world passes.
> > > The changes looks fine to me.
> >
> > Thanks for checking. Sorry, I hadn't credited Bharath as an author in
> > the commit message, so here's v7 again.
> >
>
> Patch looks good. It applies on latest commit
> 932f9fb504a57f296cf698d15bd93462ddfe2776 and make check, make
> check-world were run successfully.
>
> I will change the status to "ready for committer" in commitfest
> tomorrow. Hope that's fine.

I agree, a committer can have a look at this.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2020-07-16 17:13:51 Re: Parallel copy
Previous Message Alexey Kondratov 2020-07-16 16:56:35 Re: Partitioning and postgres_fdw optimisations for multi-tenancy