| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Subject: | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Date: | 2026-10-30 09:18:14 |
| Message-ID: | CALDaNm2L_0eJ1yKbp4OM9XdyrGHpyK3iU49nbc5hCRe3F+MPjg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 29 Oct 2026 at 21:42, Greg Burd <greg(at)burd(dot)me> wrote:
>
> Open item from review:
>
> Amit suggested [4] registering bucket_blkno only for the overflow-page
> cases, since for a primary-bucket-page record the block is already
> known, saving 4 bytes on the common records. I have not made that
> change yet; I can in the next version if we agree it is worth the extra
> branch in each redo path.
Yes, that would be better. The
v3-0002-Append-the-hash-primary-bucket-block-number-to-WA.patch patch
has the changes for the same. The v3-0001 is the same as v2-0001
posted by Greg. Please merge it if you feel the changes are ok.
I did not include the v2-0002-Remove-REGBUF_NO_CHANGE patch as we can
get to it once we bring the first patch into committable shape.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Append-the-hash-primary-bucket-block-number-to-WA.patch | application/octet-stream | 11.7 KB |
| v3-0001-Don-t-register-pin-only-primary-bucket-pages-in-h.patch | application/octet-stream | 15.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koshino Taiki | 2026-10-30 09:29:29 | Re: Proposal: Include CHECK constraint expression in violation error DETAIL |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-10-30 09:16:45 | RE: [PATCH] Preserve replication origin OIDs in pg_upgrade |