Re: Proposal: Conflict log history table for Logical Replication

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-06-16 03:57:19
Message-ID: CALDaNm2Dd2Pi2yMVWZcb_QKycD_5+DktOXukXt+sDr-OKL+4Ww@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 15 Jun 2026 at 14:20, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > 2. Views are disallowed, but functions are allowed
> > Creating a view in the pg_conflict schema is rejected:
> > postgres=# CREATE VIEW v1 AS
> > SELECT * FROM pg_conflict.pg_conflict_log_16435;
> > ERROR: permission denied to create "pg_conflict.v1"
> > DETAIL: Conflict schema modifications are currently disallowed.
> >
> > However, creating a function in the same schema succeeds:
> > CREATE FUNCTION pg_conflict.get_conflict_count()
> > RETURNS bigint
> > LANGUAGE sql
> > AS $$
> > SELECT count(*) FROM pg_conflict.pg_conflict_log_16404;
> > $$;
> > CREATE FUNCTION
> >
>
> This is okay because the function is doing SELECT which we allow on
> these tables.

Shouldn’t creating a view also be allowed for the same reason?

The function is permitted because it only performs a SELECT on the
conflict log table, and such read operations are allowed. A view
likewise represents a stored query definition and does not modify the
conflict schema or its underlying tables. Given that direct queries on
the conflict log tables are already permitted, allowing users to
define views over them is consistent with the same rationale applied
to functions.

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daisuke Higuchi 2026-06-16 04:01:48 [PATCH] Fix sequence value may rollback after CREATE DATABASE TEMPLATE with WAL_LOG strategy
Previous Message Michael Paquier 2026-06-16 03:42:46 Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope