| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Added schema level support for publication. |
| Date: | 2021-09-02 06:28:16 |
| Message-ID: | CALDaNm27bs40Rxpy4oKfV97UgsPG=vVoZ5bj9pP_4BxnO-6DYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 31, 2021 at 6:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> >
> > I have made these changes at the v23 patch attached at [1].
> >
>
> *
> +/*
> + * Invalidate the relations.
> + */
> +static inline void
> +InvalidatePublicationRels(List *relids)
>
> I don't see the need to make this an inline function.
Modified
> * On similar lines, the code in function
> GetPubPartitionOptionRelations seems to be extracted from existing
> function GetPublicationRelations(). Can't we move it into the 0001
> patch?
Modified
Thanks for the comments, the attached v24 patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v24-0001-Made-the-existing-relation-cache-invalidation-an.patch | text/x-patch | 5.9 KB |
| v24-0002-Added-schema-level-support-for-publication.patch | text/x-patch | 85.5 KB |
| v24-0003-Tests-and-documentation-for-schema-level-support.patch | text/x-patch | 62.9 KB |
| v24-0004-Alter-publication-syntax-enhancement-to-keep-it-.patch | text/x-patch | 15.6 KB |
| v24-0005-Implemented-pg_publication_objects-view.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-09-02 06:30:51 | Re: Added schema level support for publication. |
| Previous Message | Dean Rasheed | 2021-09-02 06:27:09 | Re: Numeric x^y for negative x |