| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Added schema level support for publication. |
| Date: | 2021-08-31 12:58:17 |
| Message-ID: | CAA4eK1Je4Ncg_f_WTct1-7B+5ib9AUU_f2ZrdKJeK+jMAtDvBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 31, 2021 at 9:15 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > Okay, I got it but let's add few comments in the code related to it.
> > Also, I noticed that the code in InvalidatePublicationRels() already
> > exists in AlterPublicationOptions(). You can try to refactor the
> > existing code as a separate initial patch.
>
> I have made these changes at the v23 patch attached at [1].
>
*
+/*
+ * Invalidate the relations.
+ */
+static inline void
+InvalidatePublicationRels(List *relids)
I don't see the need to make this an inline function.
* On similar lines, the code in function
GetPubPartitionOptionRelations seems to be extracted from existing
function GetPublicationRelations(). Can't we move it into the 0001
patch?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2021-08-31 13:08:47 | Re: pg_receivewal starting position |
| Previous Message | Antonin Houska | 2021-08-31 12:46:30 | Re: POC: Cleaning up orphaned files using undo logs |