| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations. |
| Date: | 2022-07-13 09:54:49 |
| Message-ID: | CALDaNm266bU_RxkbM49pHuxPmd7NP3vHCXaeDSzCPDFWAoBOJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 13, 2022 at 1:13 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 13, 2022 at 12:22:06PM +0530, vignesh C wrote:
> > Most of the code is common between GetSubscriptionRelations and
> > GetSubscriptionNotReadyRelations. Added a parameter to
> > GetSubscriptionRelations which could provide the same functionality as
> > the existing GetSubscriptionRelations and
> > GetSubscriptionNotReadyRelations. Attached patch has the changes for
> > the same. Thoughts?
>
> Right. Using all_rels to mean that we'd filter relations that are not
> ready is a bit confusing, though. Perhaps this could use a bitmask as
> argument.
The attached v2 patch has the modified version which includes the
changes to make the argument as bitmask.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Refactor-to-make-use-of-a-common-function-for-Get.patch | text/x-patch | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-07-13 09:57:35 | Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger |
| Previous Message | Aleksander Alekseev | 2022-07-13 09:25:32 | Re: i.e. and e.g. |