Re: Removed unused import modules from tap tests

On Wed, Nov 10, 2021 at 6:07 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Nov-10, Michael Paquier wrote:
>
> > I would not have bothered changing things if the names of the modules
> > were the same across stable branches to minimize merge conflicts.
> >
> > However, everything has changed on HEAD, so there is a good argument
> > for simplifying the tests as you are proposing here. Any thoughts
> > from others?
>
> I agree with your reasoning, but I wonder what's the *benefit* of
> removing those includes. IOW, what's the reason not to simply drop the
> patch?

The idea was to clean up the unused import. I noticed that generally
while adding new test files we copy from existing files, this results
in existing unused imports also being added when new tests are added.
It is just a cleanup activity to remove it from the existing code and
probably can be taken care during the review so that it does not get
added in the new tests.

Regards,
Vignesh