| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
| Subject: | Re: locking [user] catalog tables vs 2pc vs logical rep |
| Date: | 2021-03-31 12:17:50 |
| Message-ID: | CALDaNm2+RARfmUiSU-QO-Bdgy9oPVrde2astHxeSQb3+yciigQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2021 at 2:35 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> The patch applies fine on HEAD and "make check" passes fine. No major comments on the patch, just a minor comment:
>
> If you could change the error from, " cannot PREPARE a transaction that has a lock on user catalog/system table(s)"
> to "cannot PREPARE a transaction that has an exclusive lock on user catalog/system table(s)" that would be a more
> accurate instruction to the user.
>
Thanks for reviewing the patch.
Please find the updated patch which includes the fix for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fail-prepared-transaction-if-transaction-has-lock.patch | text/x-patch | 15.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-03-31 12:46:44 | Re: row filtering for logical replication |
| Previous Message | Masahiko Sawada | 2021-03-31 11:44:34 | Re: New IndexAM API controlling index vacuum strategies |