Re: Proposal: Conflict log history table for Logical Replication

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-11-19 10:06:34
Message-ID: CALDaNm1umhrtjaXbPq=HY-QmVGankE863Ys8YDJMR3H1mDKVog@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Nov 2026 at 15:56, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments and changes, I have merged the changes with
> slight changes in the 002 patch, there are no changes in 001 and 003
> patch, it is the same as the v94 version patch. The attached v95
> version patch has the changes for the same.

Few comments:
1. catalogs.sgml is missing the new pg_subscription columns:
subconflictlogrelid and subconflictlogdest

2. Should we mention "for the elements of the local_conflicts array"
instead of "for the conflict log table"
+ * build_local_conflicts_tupledesc
+ *
+ * Build and bless a tuple descriptor for the conflict log table based on the
+ * predefined LocalConflictSchema.
+ */
+static TupleDesc
+build_local_conflicts_tupledesc(void)

3. Should the relation be quoted here:
+ appendStringInfo(&err_detail,
+ _("Conflict details
are logged to the conflict log table: %s.%s."),
+
get_namespace_name(RelationGetNamespace(conflictlogrel)),
+
RelationGetRelationName(conflictlogrel));

4. Stray blank line at executor.h:
+/* Avoid including access/transam.h here */
+typedef struct FullTransactionId FullTransactionId;
+

5. typo
5.a) Should "instead index's" be "instead of index's":
+ /*
+ * See BuildIndexValueDescription() for why we
used rd_opcintype
+ * instead index's tupleDesc.
+ */

5.b)Should "have already been exited" be "have already exited"

+ * Ensure
workers have already been exited to
+ * avoid
getting prepared transactions while we

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chengpeng Yan 2026-11-19 10:30:37 Re: [PATCH] Fix encoding-dependent LIKE/regex selectivity estimates
Previous Message Zsolt Parragi 2026-11-19 09:51:55 EXPLAIN ANALYZE CREATE TABLE AS EXECUTE runs non-SELECT prepared statements