From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Document slot's restart_lsn can go backward |
Date: | 2025-07-21 08:40:00 |
Message-ID: | CALDaNm1qBC9cGeyjACxtcHtZABd9mHQ2qaQsARNXXP1BXQFiDw@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 21 Jul 2025 at 11:04, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > While working on the patch fixing the situation when slot's
> > restart_lsn ends up pointing to a removed WAL segment [1], we
> > discovered that sometimes slot's restart_lsn can go backward
> > [2][3][4]. Hayato Kuroda proposed a patch [5], which improves
> > comments by describing this behavior. As proposed by Amit Kapila [6],
> > I'm starting a new thread about this comments patch.
> >
> > Any feedback on this patch?
> >
>
> I have tried to slightly improve the comments. You can include the
> suggestions, if you and/or kuroda-san thinks that the suggestions make
> the patch better.
Your changes look good to me.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2025-07-21 08:48:27 | Re: Missing NULL check after calling ecpg_strdup |
Previous Message | shveta malik | 2025-07-21 07:35:30 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |