| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ordering of header file inclusion |
| Date: | 2019-10-20 17:31:00 |
| Message-ID: | CALDaNm1jRMHUn7ZH8h3LZr_L=-hmMK8N_fGaJ-jwjv_HBN8QEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 20, 2019 at 1:20 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
> index f9fe57f..6224735 100644
> --- a/contrib/bloom/blcost.c
> +++ b/contrib/bloom/blcost.c
> @@ -12,10 +12,10 @@
> */
> #include "postgres.h"
>
> +#include "bloom.h"
> #include "fmgr.h"
> #include "utils/selfuncs.h"
>
> -#include "bloom.h"
>
> /*
> * Estimate cost of bloom index scan.
>
> This class of change I don't like.
>
> The existing arrangement keeps "other" header files separate from the
> header file of the module itself. It seems useful to keep that separate.
>
Thanks Peter for your thoughts, I have modified the changes based on
your suggestions.
I have included the module header file in the beginning.
The changes are attached in the previous mail.
Please let me know your suggestions for any changes.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2019-10-20 17:32:31 | Re: Ordering of header file inclusion |
| Previous Message | vignesh C | 2019-10-20 17:28:03 | Re: Ordering of header file inclusion |