| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: alter table set TABLE ACCESS METHOD |
| Date: | 2021-07-22 05:07:12 |
| Message-ID: | CALDaNm1f_6DoFycXBVu6fEKeWjm3Xf3gSM5TDp13tiMY3zpThw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> rebased.
>
> Also, there were two redundant checks for multiple SET ACCESS METHOD commands.
> But one of them wasn't hit if the ALTER was setting the current AM due to the
> no-op test.
>
> I think it's better to fail in every case, and not just sometimes (especially
> if we were to use ERRCODE_SYNTAX_ERROR).
>
> I included my 2ndary patch allowing to set the AM of partitioned table, same as
> for a tablespace.
One of the tests is failing, please post an updated patch for this:
create_am.out 2021-07-22 10:34:56.234654166 +0530
@@ -177,6 +177,7 @@
(1 row)
-- CREATE TABLE .. PARTITION BY supports USING
+-- new partitions will inherit from the current default, rather the
partition root
CREATE TABLE tableam_parted_heap2 (a text, b int) PARTITION BY list
(a) USING heap2;
SET default_table_access_method = 'heap';
CREATE TABLE tableam_parted_a_heap2 PARTITION OF tableam_parted_heap2
FOR VALUES IN ('a');
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-07-22 05:10:44 | Re: Next Steps with Hash Indexes |
| Previous Message | Pavel Stehule | 2021-07-22 04:12:57 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |